Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add warning log to Hashicorp Vault resolveSecret function #3535

Merged
merged 4 commits into from
Oct 13, 2023
Merged

feat: Add warning log to Hashicorp Vault resolveSecret function #3535

merged 4 commits into from
Oct 13, 2023

Conversation

awellnitz-materna
Copy link
Contributor

What this PR changes/adds

Add warning log to Hashicorp Vault resolveSecret function.

Why it does that

If the secret cannot be resolved, it is currently difficult to find out why.
The log should help the developer to find the bug faster.

Linked Issue(s)

Closes #3462

github-actions[bot]
github-actions bot reviewed Oct 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@paullatzelsperger paullatzelsperger removed their request for review October 13, 2023 05:42
@paullatzelsperger
Copy link
Member

took myself off as a reviewer, because the changeset isn't so huge :)

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (12f1275) 72.24% compared to head (4115171) 63.90%.

❗ Current head 4115171 differs from pull request most recent head f6d369f. Consider uploading reports for the commit f6d369f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3535      +/-   ##
==========================================
- Coverage   72.24%   63.90%   -8.34%     
==========================================
  Files         863      863              
  Lines       17306    17309       +3     
  Branches      986      986              
==========================================
- Hits        12502    11061    -1441     
- Misses       4392     5873    +1481     
+ Partials      412      375      -37
Files Coverage Δ
...rg/eclipse/edc/vault/hashicorp/HashicorpVault.java 100.00% <100.00%> (ø)

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jimmarino
jimmarino approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jimmarino jimmarino added the enhancement New feature or request label Oct 13, 2023
@jimmarino
Copy link
Contributor

@awellnitz-materna please fix the failing check and I will merge the PR

@awellnitz-materna
Copy link
Contributor Author

@jimmarino I have not customized any dependency. Can you tell me how to regenerate the dependency file?

@wolf4ood
Copy link
Contributor

Hi @awellnitz-materna

for the dependencies you can check the failing run of the license check. It suggests which the updated content of the DEPENDENCIES file should be.

Check

https://github.com/eclipse-edc/Connector/actions/runs/6506078793/job/17671039514?pr=3535#step:6:81

@jimmarino jimmarino merged commit bd098f5 into eclipse-edc:main Oct 13, 2023
16 checks passed
@awellnitz-materna awellnitz-materna deleted the feature/warning-log-vault-extension branch October 13, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jimmarino jimmarino jimmarino approved these changes

@bscholtes1A bscholtes1A bscholtes1A approved these changes

@ndr-brt ndr-brt ndr-brt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The HashiCorp Vault Secret resolution only returns a Secret or Null
7 participants
@awellnitz-materna @paullatzelsperger @codecov-commenter @jimmarino @wolf4ood @ndr-brt @bscholtes1A